New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: prefer fs.MapFS to os.File #136

Merged

cristaloleg merged 1 commit into cristalhq:main from tmzane:use-fs-map-in-tests

Oct 15, 2022

Collaborator

tmzane commented Oct 14, 2022

This change utilize Loader's ability to read from any fs.FS: we can use the in-memory implementation to minimize interacting with OS.

We could also use t.Setenv instead of os.Setenv but this would require bumping Go version to 1.17


          test: prefer fs.MapFS to os.File

ffc0338

cristaloleg approved these changes

View reviewed changes

Member

cristaloleg left a comment

WOW, I didn't know that we have this package, nice!

cristaloleg merged commit 7672f5b into cristalhq:main

tmzane deleted the use-fs-map-in-tests branch

October 15, 2022 10:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet