Skip to content

Commit

Permalink
fix(autocomplete): provide horizontal fallback positions
Browse files Browse the repository at this point in the history
The positions for the autocomplete dropdown are set up assuming that the panel's width will match the input so they don't provide fallbacks along the x axis. Since we have a `panelWidth` input, the consumer might've overwritten the width to something different so we need to provide the fallbacks to ensure that the panel is always inside the viewport.

Fixes angular#18854.
  • Loading branch information
crisbeto committed Mar 24, 2020
1 parent 16e2cf0 commit b18c091
Showing 1 changed file with 18 additions and 20 deletions.
38 changes: 18 additions & 20 deletions src/material/autocomplete/autocomplete-trigger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -694,32 +694,30 @@ export class MatAutocompleteTrigger implements ControlValueAccessor, AfterViewIn

/** Sets the positions on a position strategy based on the directive's input state. */
private _setStrategyPositions(positionStrategy: FlexibleConnectedPositionStrategy) {
const belowPosition: ConnectedPosition = {
originX: 'start',
originY: 'bottom',
overlayX: 'start',
overlayY: 'top'
};
const abovePosition: ConnectedPosition = {
originX: 'start',
originY: 'top',
overlayX: 'start',
overlayY: 'bottom',

// The overlay edge connected to the trigger should have squared corners, while
// the opposite end has rounded corners. We apply a CSS class to swap the
// border-radius based on the overlay position.
panelClass: 'mat-autocomplete-panel-above'
};
// Note that we provide horizontal fallback positions, even though by default the dropdown
// width matches the input, because consumers can override the width. See #18854.
const belowPositions: ConnectedPosition[] = [
{originX: 'start', originY: 'bottom', overlayX: 'start', overlayY: 'top'},
{originX: 'end', originY: 'bottom', overlayX: 'end', overlayY: 'top'}
];

// The overlay edge connected to the trigger should have squared corners, while
// the opposite end has rounded corners. We apply a CSS class to swap the
// border-radius based on the overlay position.
const panelClass = 'mat-autocomplete-panel-above';
const abovePositions: ConnectedPosition[] = [
{originX: 'start', originY: 'top', overlayX: 'start', overlayY: 'bottom', panelClass},
{originX: 'end', originY: 'top', overlayX: 'end', overlayY: 'bottom', panelClass}
];

let positions: ConnectedPosition[];

if (this.position === 'above') {
positions = [abovePosition];
positions = abovePositions;
} else if (this.position === 'below') {
positions = [belowPosition];
positions = belowPositions;
} else {
positions = [belowPosition, abovePosition];
positions = [...belowPositions, ...abovePositions];
}

positionStrategy.withPositions(positions);
Expand Down

0 comments on commit b18c091

Please sign in to comment.