fix(content): fix dynamic document.body #150

use up-to-date document.doby in case it got replaced by other scripts
crimx · Jun 27, 2018 · 27f2787 · 27f2787
1 parent ca0d8a1
commit 27f2787
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/src/content/components/DictPanelPortal/index.tsx b/src/content/components/DictPanelPortal/index.tsx
@@ -85,12 +85,16 @@ export default class DictPanelPortal extends React.Component<DictPanelPortalProp
   }
 
   mountEL = () => {
+    // body could be replaced by other scripts
+    if (!isSaladictPopupPage) { this.root = document.body }
     this.root.appendChild(this.el)
     this.isMount = true
   }
 
   unmountEL = () => {
     this.frame = null
+    // body could be replaced by other scripts
+    if (!isSaladictPopupPage) { this.root = document.body }
     this.root.removeChild(this.el)
     this.isMount = false
   }

diff --git a/src/content/components/SaladBowlPortal/index.tsx b/src/content/components/SaladBowlPortal/index.tsx
@@ -11,7 +11,6 @@ interface SaladBowlPortalProps {
 }
 
 export default class SaladBowlPortal extends React.Component<SaladBowlPortalProps> {
-  root = document.body
   el = document.createElement('div')
   bowl: null | HTMLElement = null
   isMount = false
@@ -44,7 +43,7 @@ export default class SaladBowlPortal extends React.Component<SaladBowlPortalProp
   }
 
   componentWillUnmount () {
-    this.root.removeChild(this.el)
+    document.body.removeChild(this.el)
   }
 
   renderBowl = () => {
@@ -56,12 +55,12 @@ export default class SaladBowlPortal extends React.Component<SaladBowlPortalProp
     const { shouldShow, isAnimation } = this.props
     if (shouldShow) {
       if (!this.isMount) {
-        this.root.appendChild(this.el)
+        document.body.appendChild(this.el)
         this.isMount = true
       }
     } else {
       if (this.isMount) {
-        this.root.removeChild(this.el)
+        document.body.removeChild(this.el)
         this.isMount = false
       }
     }

diff --git a/src/content/components/WordEditorPortal/index.tsx b/src/content/components/WordEditorPortal/index.tsx
@@ -18,7 +18,6 @@ export interface WordEditorPortalProps extends Omit<
 
 export default class WordEditorPortal extends React.Component<WordEditorPortalProps> {
   isMount = false
-  root = document.body
   el = document.createElement('div')
   frameHead = '<meta name="viewport" content="width=device-width, initial-scale=1">\n' + (
     process.env.NODE_ENV === 'production'
@@ -52,12 +51,12 @@ export default class WordEditorPortal extends React.Component<WordEditorPortalPr
   }
 
   mountEL = () => {
-    this.root.appendChild(this.el)
+    document.body.appendChild(this.el)
     this.isMount = true
   }
 
   unmountEL = () => {
-    this.root.removeChild(this.el)
+    document.body.removeChild(this.el)
     this.isMount = false
   }