ci: add node versions to matrix #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@ledbit anything that's needed now? I noticed all the builds cancelled I'm guessing that's because of a resource limit or because this is a PR by a user without write access? |
ledbit
requested changes
Nov 12, 2020
Comment on lines
+5
to
+7
| - 12.x | ||
| - 13.x | ||
| - 14.x |
There was a problem hiding this comment.
These would have to be full node versions. Also, I believe there is a maximum number of parallel pipelines allowed by Azure.
It would also be quite wasteful to rebuild all the versions all the time - ideally we'd have a script that checks the available versions of nodejs and just builds what;s not built already
There was a problem hiding this comment.
Not really sure how 9 builds is "wasteful".
ideally we'd have a script that checks the available versions of nodejs and just builds what;s not built already
What do you mean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses parameterized jobs to allow a better matrix which not only has platforms but also node versions.
This now supports the following matrix.
Feel free to make additional commits if need be.