Smooth trailing 7days, and smooth *before* calculating proportions #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves all the short-window imprecision to the earliest data, avoiding transient large swings in the most recent three days of data.
This shares our calculation logic and avoids inflating random noise in the downloads out of proportion due to order of operations.
|
Brilliant work, thanks @Zac-HD for taking my PR and making it better! |
|
@crflynn - anything I can do to help get this merged? |
|
@crflynn - ping, it's been a while but I'd still like to get this merged so that I can understand my download numbers. Anything I can do to help, or can you merge it as-is? |
|
Closing this just to get it off my stack of open PRs 😕 |
|
Sad :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21 and closes #25 (with thanks to @scottgigante). The two differences to #25 are that
Instead of centering the smoothing window, we use the trailing seven days. This means that the effect of the shorter window does not impact the most recent days of data, which is where maintainers tend to be most concerned - otherwise there would be a big dip on weekends when the window was Thurs-Sun and not yet brought back up by Mon-Tues.
The proportional calculations have been refactored from "average of proportions" to "proportion of averages" - which is much less impacted by random variations, and the obvious interpretation when the plain averages are visible in the previous chart.
@crflynn - I'm keen to get this merged soon, is there anything I can do to help that?