Skip to content

Commit

Permalink
preflight: Improve 'removeCrcVM' description
Browse files Browse the repository at this point in the history
  • Loading branch information
cfergeau authored and praveenkumar committed Oct 12, 2021
1 parent bda62b7 commit 3e9b6b6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pkg/crc/preflight/preflight_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func libvirtPreflightChecks(distro *linux.OsRelease) []Check {
labels: labels{Os: Linux},
},
{
cleanupDescription: "Removing the crc VM if exists",
cleanupDescription: "Removing crc's virtual machine",
cleanup: removeCrcVM,
flags: CleanUpOnly,

Expand Down
2 changes: 1 addition & 1 deletion pkg/crc/preflight/preflight_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ var hypervPreflightChecks = []Check{
labels: labels{Os: Windows},
},
{
cleanupDescription: "Removing the crc VM if exists",
cleanupDescription: "Removing crc's virtual machine",
cleanup: removeCrcVM,
flags: CleanUpOnly,

Expand Down
4 changes: 2 additions & 2 deletions test/e2e/features/basic.feature
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ Feature: Basic test
@linux
Scenario Outline: CRC clean-up
When executing crc cleanup command succeeds
Then stderr should contain "Removing the crc VM if exists"
Then stderr should contain "Removing crc's virtual machine"
And stderr should contain "Removing 'crc' network from libvirt"
And stderr should contain "Using root access: Executing systemctl daemon-reload command"
And stderr should contain "Using root access: Executing systemctl reload NetworkManager"
Expand All @@ -202,7 +202,7 @@ Feature: Basic test
When executing crc cleanup command succeeds
Then stderr should contain "Uninstalling tray if installed"
Then stderr should contain "Uninstalling daemon if installed"
And stderr should contain "Removing the crc VM if exists"
And stderr should contain "Removing crc's virtual machine"
And stderr should contain "Removing dns server from interface"
And stderr should contain "Will run as admin: Remove dns entry for default switch"
And stdout should contain "Cleanup finished"

0 comments on commit 3e9b6b6

Please sign in to comment.