Propose to initialise if setup not finished #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <[email protected]>
gbraad
reviewed
Apr 24, 2023
| | 'No Cluster' | ||
| | 'Error' | ||
| | 'Unknown' | ||
| | 'Need Setup'; |
There was a problem hiding this comment.
this can also be used to set the tray to show a Setup option instead of Start/Stop when not finished yet.
There was a problem hiding this comment.
I think it is an enhancement for PD, as we don’t add start/stop tray items, it automatically added by PD when crc-ext register provider lifecycle object.
gbraad
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add check for
crc setupstate, and if crc requires to callsetup, it propose to do that withinitialisebutton on dashboard.Related issue #39
Demo:
Setup.Demo.1.mp4