Implement CRC CLI update #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <[email protected]>
gbraad
reviewed
Jul 13, 2023
gbraad
reviewed
Jul 13, 2023
gbraad
reviewed
Jul 13, 2023
gbraad
reviewed
Jul 13, 2023
gbraad
reviewed
Jul 13, 2023
src/install/crc-install.ts
Outdated
| return undefined; | ||
| } | ||
|
|
||
| async doUpdate( |
There was a problem hiding this comment.
Please call this something like AskForUpdate
gbraad
reviewed
Jul 13, 2023
| provider.updateVersion(crcVersion.version); | ||
| this.crcCliInfo.ignoreVersionUpdate = undefined; | ||
| } else if (answer === 'Ignore') { | ||
| this.crcCliInfo.ignoreVersionUpdate = updateInfo.newVersion.version.crcVersion; |
There was a problem hiding this comment.
Is there a way to still install this update?
People might ignore it, meaning ignore for now.
There was a problem hiding this comment.
They have Cancel button.
I could rename Ignore to Ignore %{version}.
There was a problem hiding this comment.
This does make sense if expressed this way.
There was a problem hiding this comment.
let's put this in a new issue... but not implement this yet.
as I see this is also in the answer === check
gbraad
requested changes
Jul 13, 2023
Signed-off-by: Yevhen Vydolob <[email protected]>
gbraad
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update UI(button) are provided by P-D API.
Resolve #37
Demo:
Screen.Recording.2023-07-07.at.09.42.22.mp4