Single layer extension container #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbraad
previously requested changes
May 25, 2023
There was a problem hiding this comment.
This does not solve the request where they expect a single layer
#138
You will have:
COPY --from=builder /opt/app-root/src/... /extension
COPY --from=builder /opt/app-root/src/dist /extension/dist
So still two layers.
This needs a modifcation to the build process so only a single
folder is needed. Why not doing the folder setup in the builder
part, so that:
COPY --from=builder /opt/app-root/src/dist/extension /extension
would suffice.
Note: At the moment a low(er) priority.
|
@evidolob @anjannath I addressed the issues of Praveen's PR. Please have a look |
gbraad
changed the title
anjannath
approved these changes
May 30, 2023
|
thank you guys 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138