Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle need to recreate and cancel #131

Merged
merged 1 commit into from
May 25, 2023

Conversation

gbraad
Copy link
Contributor

@gbraad gbraad commented May 23, 2023

The user can cancel the preset with 'cancel' (and 'X') and will only ask the user to delete the preset when it differs from the current one.

@gbraad gbraad requested a review from evidolob May 23, 2023 12:24
src/preferences.ts Outdated Show resolved Hide resolved
@gbraad gbraad force-pushed the handle-recreate-cancel branch from ffb79ba to 57cb50e Compare May 23, 2023 13:39
src/preferences.ts Outdated Show resolved Hide resolved
@evidolob
Copy link
Contributor

Preset change doesn’t work for me, whatever I select on preset list, it doesn’t applied on crc config

@gbraad
Copy link
Contributor Author

gbraad commented May 24, 2023

I tried this again and works
image

I set the preset to microshift on start. the bottom powershell shows this. I change it to openshift... but have to wait quite long before the dialog shows... I check the value and it removed microshift.
then when I 'cancel' (or 'X') it will default BACK to microshift as you cancelled. any other value will perform the delete as instructed.

I do not prevent the configSet to happen... I only perform an 'undo' at the time the user cancels.

@gbraad gbraad changed the title [WIP] Handle need to recreate and cancel Handle need to recreate and cancel May 24, 2023
@gbraad gbraad force-pushed the handle-recreate-cancel branch from 57cb50e to 70953dc Compare May 24, 2023 05:15
@gbraad gbraad force-pushed the handle-recreate-cancel branch from 70953dc to 54b6715 Compare May 24, 2023 06:30
@evidolob
Copy link
Contributor

Preset change still doesn’t work for me:

Screen.Recording.2023-05-24.at.09.59.18.mp4

@gbraad
Copy link
Contributor Author

gbraad commented May 24, 2023

For you, the whole dialog doesn't even pop up to "recreate". Can you see if the event actually goes through, or if there is an error ?

@gbraad
Copy link
Contributor Author

gbraad commented May 24, 2023

@evidolob you mentioned something else is the root cause of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants