Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register commands only if crc installed #126

Merged
merged 1 commit into from
May 18, 2023

Conversation

evidolob
Copy link
Contributor

That fix adding commands in a tray with temp provider.
So we will add commands only if crc cli is installed.

@evidolob evidolob requested a review from gbraad May 18, 2023 07:37
Copy link
Contributor

@gbraad gbraad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't been able to test this, but looks like:

  if version is given, the daemon is functional; then
       when cluster is available
             do register
       else
             show which preset is selected

@evidolob evidolob merged commit f975968 into crc-org:main May 18, 2023
@evidolob evidolob deleted the fix-register-commands branch May 18, 2023 11:31
@evidolob evidolob restored the fix-register-commands branch May 18, 2023 11:31
@evidolob evidolob deleted the fix-register-commands branch May 18, 2023 11:31
@evidolob evidolob restored the fix-register-commands branch May 18, 2023 11:31
@evidolob evidolob deleted the fix-register-commands branch May 18, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants