binary/encode: don't encode lowercase strings as hex

Should fix tulir#666 Closes tulir#738
crazycodezombie · Feb 8, 2025 · 330f724 · 330f724
1 parent 9cb0c84
commit 330f724
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/binary/encoder.go b/binary/encoder.go
@@ -286,7 +286,7 @@ func validateHex(value string) bool {
 		return false
 	}
 	for _, char := range value {
-		if !(char >= '0' && char <= '9') && !(char >= 'A' && char <= 'F') && !(char >= 'a' && char <= 'f') {
+		if !(char >= '0' && char <= '9') && !(char >= 'A' && char <= 'F') {
 			return false
 		}
 	}
@@ -299,8 +299,6 @@ func packHex(value byte) byte {
 		return value - '0'
 	case value >= 'A' && value <= 'F':
 		return 10 + value - 'A'
-	case value >= 'a' && value <= 'f':
-		return 10 + value - 'a'
 	case value == 0:
 		return 15
 	default: