Added CloseableIterator interface #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Klock <[email protected]>
klockla
added
Server
rocksDB
jnioche
reviewed
Nov 25, 2024
service/src/main/java/crawlercommons/urlfrontier/service/rocksdb/RocksDBService.java
Show resolved
Hide resolved
Correct, the goal here was to close the RocksDbIterator used by the Iterator as soon as possible |
jnioche
approved these changes
Nov 26, 2024
…nt radix) everywhere Signed-off-by: Laurent Klock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added close to the Iterator Needed when we need to close resources used by the Iterator
(e.g. The RocksDBIterator in case of RocksDb implementation).