Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use replace instead of replaceall #113

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Use replace instead of replaceall #113

merged 1 commit into from
Nov 19, 2024

Conversation

klockla
Copy link
Collaborator

@klockla klockla commented Nov 19, 2024

replaceall expects a regex as first argument and uses Pattern.compile(regex) (performance overhead)

@klockla
Use replace instead of replaceall
1f3c895 
replaceall expects a regex as first argument and uses Pattern.compile(regex) (performance overhead)

Signed-off-by: Laurent Klock <[email protected]>
@klockla klockla requested a review from jnioche November 19, 2024 10:14
@klockla klockla removed the request for review from jnioche November 19, 2024 13:13
@klockla klockla merged commit dd80796 into crawler-commons:master Nov 19, 2024
2 checks passed
@klockla klockla deleted the fix-replace-underscore branch November 19, 2024 13:17
@klockla klockla added enhancement New feature or request Server labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzo1 rzo1 rzo1 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klockla @rzo1