Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable grpc server reflection #112

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

jdpedrie
Copy link
Contributor

This PR adds support for server reflection, enabling the use of tools like grpcui.

@jnioche jnioche added the enhancement New feature or request label Oct 30, 2024
@jnioche
Copy link
Collaborator

jnioche commented Oct 30, 2024

Thanks @jdpedrie
Any drawbacks in using it? I assume this won't affect performance in any way

@jdpedrie
Copy link
Contributor Author

Not according to this stackoverflow answer. I would imagine the service would be deployed either for testing/development, or in an internal environment, but it might still make sense to place it behind a config flag.

@jnioche
Copy link
Collaborator

jnioche commented Oct 31, 2024

but it might still make sense to place it behind a config flag.

+1

@jdpedrie
Copy link
Contributor Author

Done in the latest commit.

@jnioche jnioche added this to the 2.5 milestone Nov 1, 2024
@jnioche jnioche merged commit 5caede6 into crawler-commons:master Nov 1, 2024
2 checks passed
@jnioche
Copy link
Collaborator

jnioche commented Nov 1, 2024

thanks @jdpedrie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants