Add support for passing flags as strings #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves crate-py#51 There is no support for `Flags` structs as provided by the `regress` crate. But a string can be passed down and is converted to Flags by the `with_flags` constructor. Exposing flags as a struct/enum adds significant complexity deemed not worth the additional code at this time. (See crate-py#51 for more details.) A python test verifies that the alternate constructor pattern works and provides support for the `"u"` flag.
|
I'll try to look at this tomorrow, but just because it's a common thing to forget (until PyO3/pyo3#2454 is resolved) -- can you update the |
|
I just pushed a change for the type-stubs. I didn't realize that was independent of the pyo3 process. |
|
OK, let's go with this for now then, can always give the other implementation another shot down the line. Appreciated as usual! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #51
There is no support for
Flagsstructs as provided by theregresscrate. But a string can be passed down and is converted to Flags by thewith_flagsconstructor.Exposing flags as a struct/enum adds significant complexity deemed not worth the additional code at this time. (See #51 for more details.)
A python test verifies that the alternate constructor pattern works and provides support for the
"u"flag.EDIT: 🤫 minor force-push. I botched the style rule by removing a line of whitespace by mistake.