Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove TODO pertaining to 128 bit scalars #178

Merged
merged 1 commit into from
Aug 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cryptography/kzg_multi_open/src/fk20/verifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,7 @@ fn compute_fiat_shamir_challenge(
// This is noted because when we convert a 256 bit hash to a scalar, a bias will be introduced.
// This however does not affect our security guarantees because the bias is negligible given we
// want a uniformly random 128 bit integer.

// TODO: computing powers will remove the 128 bit structure, consider generating `n` 128 bit scalars
//
// Also there is a negligible probably that the scalar is zero, so we do not handle this case here.
reduce_bytes_to_scalar_bias(result)
}
Expand Down
Loading