Change Scalar::new input from u128 to BigUint #4
Conversation
| let bls_modulus = BigUint::from_str(BLS_MODULUS).unwrap(); | ||
| let base_bigint = BigUint::from_bytes_le(self.to_le_bytes()?.as_slice()); | ||
| let exp_bigint = BigUint::from_bytes_le(exp.to_le_bytes()?.as_slice()); | ||
| let result = base_bigint.modpow(&exp_bigint, &bls_modulus); | ||
| Ok(Scalar( | ||
| ark_bls12_381::Fr::from_str(&*result.to_string()).map_err(|_| { | ||
| exceptions::PyValueError::new_err("Failed to convert result to scalar") | ||
| })?, | ||
| )) | ||
| } |
There was a problem hiding this comment.
Not blocking as we can speed this up after -- Fr should have a pow method that one can use too, which should allow us to remove the BLS_MODULUS import
There was a problem hiding this comment.
Unfortunately it's exponent parameter is a u32, so it won't work for us 😢
There was a problem hiding this comment.
I think its more than a u32, last time I checked or that would be almost unusable!
There was a problem hiding this comment.
It might have been &[u32] or something of that nature
There was a problem hiding this comment.
Ah you're right. I can fix this! Here's a screenshot of the method:
I must have misinterpreted it. Good catch!
There was a problem hiding this comment.
No worries! Feel free to push another PR when ready :)
There was a problem hiding this comment.
Made this PR:
| // Bug, Fr::to_string will print nothing if the value is zero | ||
| BigUint::from_str(&*self.0.to_string()).unwrap_or(BigUint::ZERO) |
There was a problem hiding this comment.
Also not blocking: I've tried to avoid the str method in arkworks in place of using hex since the .to_string method had weird behaviours last time I checked and the way it was doing the conversion seemed non-optimal
There was a problem hiding this comment.
Good call. Made this PR:
|
Merging as comments were non-blocking |
This PR does these things:
pyo3to the latest version.num-bigintfeature which allows us to use bigints.Scalar::newmethod to takeBigUintinstead ofu128.examples/scalar.pyto ensure it works.__truediv__to allow scalar division.__int__so we can convert back to an integer in Python.