rope_htmlrender: fix some HTML rendering bugs #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crashappsec/chalk#178.
Consider this HTML:
Before this PR, if we converted that to a
Rope
then calledtoHtml
, we'd get invalid HTML:The errors:
<td>
pair around each cell<tr>
anywhere<caption>
at the bottom, but<caption>
must be the first child of<table>
See the errors when pasting into https://validator.w3.org/#validate_by_input.
With this PR,
toHtml
produces valid HTML for that input:which prettifies to something that's the same as the input, except: