rope_htmlrender: remove nested caption tags

Before this commit: <caption> <caption> Commands </caption> </caption> With this commit: <caption> Commands </caption>
crashappsec · Feb 21, 2024 · 55f6acb · 55f6acb
1 parent a275429
commit 55f6acb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/nimutils/rope_htmlrender.nim b/nimutils/rope_htmlrender.nim
@@ -67,7 +67,9 @@ proc toHtml*(r: Rope, indent = 0): string =
       caption = element("caption", title)
       title   = ""
     elif caption != "":
-      caption = element("caption", caption)
+      let i = caption.find('<')
+      if not caption.continuesWith("<caption>", i):
+        caption = element("caption", caption)
 
     result = nobreak("table", caption & thead & tbody & tfoot)
 

diff --git a/tests/tests.nim b/tests/tests.nim
@@ -215,6 +215,7 @@ suite "ropes":
   test "rope_htmlrender":
     const s = """
       <table>
+        <caption>Commands</caption>
         <tbody>
           <tr>
             <th>Command Name</th>
@@ -237,6 +238,10 @@ suite "ropes":
 
       <div>
       <table>
+      <caption>
+      Commands
+      </caption>
+
       <tbody>
 
       <tr>