refactor: reduce usage of autogenerated getters, part 2

[ee7]

Issue

#214

Description

Continue from 66a5bb4, but operate on the top-level fields of ChalkConfig that have a simpler type.

With this PR, running the following command in the repo root no longer returns any matches:

git grep 'chalkConfig.get' 

These also don't return any match:

git grep 'get(chalkConfig' 

git grep 'get chalkConfig' 

ChalkConfig currently gets defined as the below, with added comments and newlines to clarify the current status. Essentially, the remaining fields are getoptsObjs and those of type OrderedTableRef.

type ChalkConfig* = ref object
  `@@attrscope@@`*: AttrScope
  # The below 12 fields will be handled later
  getoptsObjs*: GetoptsType
  keyspecs*: OrderedTableRef[string, KeySpec]
  plugins*: OrderedTableRef[string, PluginSpec]
  sinks*: OrderedTableRef[string, SinkSpec]
  sinkConfs*: OrderedTableRef[string, SinkConfigObj]
  auths*: OrderedTableRef[string, AuthSpec]
  authConfs*: OrderedTableRef[string, AuthConfigObj]
  markTemplates*: OrderedTableRef[string, MarkTemplate]
  reportTemplates*: OrderedTableRef[string, ReportTemplate]
  outputConfigs*: OrderedTableRef[string, OutputConfig]
  reportSpecs*: OrderedTableRef[string, ReportSpec]
  tools*: OrderedTableRef[string, ToolInfo]

  # The below 8 fields were handled by #235
  attestationConfig*: AttestationConfig
  extractConfig*: ExtractConfig
  dockerConfig*: DockerConfig
  execConfig*: ExecConfig
  loadConfig*: LoadConfig
  envConfig*: EnvConfig
  srcConfig*: SrcConfig
  cloudProviderConfig*: CloudProviderConfig

  # The below 2 fields will be handled later
  techStackRules*: OrderedTableRef[string, TechStackRule]
  linguist_languages*: OrderedTableRef[string, LinguistLanguage]

  # All the below fields should be handled by this PR
  config_path*: seq[string]
  config_filename*: string
  valid_chalk_command_names*: seq[string]
  valid_chalk_commands*: seq[string]
  ignore_when_normalizing*: seq[string]
  default_command*: Option[string]
  selected_command*: string
  color*: Option[bool]
  log_level*: string
  chalk_log_level*: string
  virtual_chalk*: bool
  zip_extensions*: seq[string]
  pyc_extensions*: seq[string]
  con4m_pinpoint*: bool
  chalk_debug*: bool
  cache_fd_limit*: int
  publish_audit*: bool
  report_total_time*: bool
  audit_location*: string
  audit_file_size*: Con4mSize
  log_search_path*: seq[string]
  artifact_search_path*: seq[string]
  default_tmp_dir*: Option[string]
  always_try_to_sign*: bool
  inform_if_cant_sign*: bool
  use_transparency_log*: bool
  use_signing_key_backup_service*: bool
  signing_key_backup_service_url*: string
  signing_key_backup_service_auth_config_name*: string
  signing_key_backup_service_timeout*: Con4mDuration
  signing_key_location*: string
  ignore_patterns*: seq[string]
  load_external_config*: bool
  load_embedded_config*: bool
  run_sbom_tools*: bool
  run_sast_tools*: bool
  recursive*: bool
  docker_exe*: Option[string]
  chalk_contained_items*: bool
  show_config*: bool
  ktype_names*: seq[string]
  use_report_cache*: bool
  report_cache_location*: string
  report_cache_lock_timeout_sec*: int
  force_output_on_reporting_fails*: bool
  env_always_show*: seq[string]
  env_never_show*: seq[string]
  env_redact*: seq[string]
  env_default_action*: string
  aws_iam_role*: Option[string]
  skip_command_report*: bool
  skip_summary_report*: bool
  symlink_behavior*: string
  install_completion_script*: bool
  use_pager*: bool
  crashoverride_usage_reporting_url*: string
  crashoverride_workspace_id*: string
  use_tech_stack_detection*: bool

Refs: #214

Testing

Hopefully the current tests are sufficient.

[ee7]

Note that removing get and transforming from PascalCase to snake_case is not quite sufficient.

For example, we do currently want:

-    uri     = chalkConfig.getCrashOverrideUsageReportingUrl()
+    uri     = get[string](chalkConfig, "crashoverride_usage_reporting_url")

not crash_override_usage_reporting_url. In the future, I'll suggest that we enable styleCheck and make identifiers more consistent.