Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: falling back to mozilla CAs when system has no certs #196

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

miki725
Copy link
Collaborator

@miki725 miki725 commented Feb 8, 2024

Issue

➜ docker run -it --rm ghcr.io/crashappsec/chalk:0.3.3-dev load https://chalkdust.io/connect.c4m
warn:  ~/.local/chalk/chalk.log: could not resolve sink filename. disabling sink
warn:  default_out: sink is not enabled and cannot be subscribed for topic report
warn:  default_out: sink is not enabled and cannot be subscribed for topic audit
info:  Attempting to load module from: https://chalkdust.io/connect.c4m
error: No SSL/TLS CA certificates found.

Description

this will allow chalk to communicate with external APIs even when system has no certs such as in busybox containers

most of the change is in nimutils and then its bubbled up to con4m and chalk

Testing

existing tests cover SSL coverage. to test busybox case:

➜ docker run -it --rm -v $PWD:$PWD -w $PWD busybox ./chalk --debug load https://chalkdust.io/connect.c4m

this will allow chalk to communicate with external APIs even when system
has no certs such as in busybox containers

most of the change is in nimutils and then its bubbled up to con4m and
chalk
Copy link
Contributor

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miki725 miki725 merged commit 99bdc08 into main Feb 16, 2024
2 checks passed
@miki725 miki725 deleted the ms/tls branch February 16, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants