Mitsubishi 112 #947
Merged
Mitsubishi 112 #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Power status working. Temp and mode not working as yet.
Mitsubishi112
Mitsubishi112
crankyoldgit
reviewed
Oct 6, 2019
|
P.S. You should add yourself to the following places as a contributor, as this is a major piece of work. e.g. and please add yourself to the top of |
* TCL112 and MITSUBISHI112 use the same decoder with timing values that overlap. This caused incorrect decodes. Resolved using a shared decode() routine that tries to tell the difference based on the HdrMark length. * Share some other common code with TCL112. * Re-enable protocol check in Unit Test for Mitsubishi112. * Clean up some minor issues found in code review. For #945 & #947 FYI @kuchel77
Mitsubishi112
This reverts commit 1060e52.
|
That should be most of the changes fixed. All of tests seem to work fine now that the TCL code has merged with this. |
crankyoldgit
approved these changes
Oct 12, 2019
|
Looks okay to me. Just the question on the SwingV/SwingH remaining, then I'm happy to merge. |
crankyoldgit
added a commit
that referenced
this pull request
Oct 21, 2019
crankyoldgit
added a commit
that referenced
this pull request
Oct 30, 2019
_v2.7.0 (20191030)_ **[Bug Fixes]** - auto_analyse: Fix > 64 bit send code generation. (#976) - auto_analyse: Fix missing arguments in generated code for send64+ (#972) - IRsendProntoDemo: Fix compile issue on ESP32 platform. (#938) - IRMQTTServer: Fix compile error when `MQTT_ENABLE` is false. (#933) **[Features]** - Add Hitachi 424 bit A/C support. (#975, #980, #981) - Experimental detailed support for `DAIKIN152` (#971) - Mitsubishi 112bit A/C support (#947, #968) - gc_decode: Adding Support for Decoding codes in raw code format (#963) - Refactor to use common routines/macros to handle bit manipulation. (#934) - Use centralised common strings. Saves ~1.5k of program space. (#946) - Add Internationalisation (i18n) / Locale support. (#946, #955, #966) - `de-CH`: Swiss German. (#949, #954) - `de-DE`: German. (#946, #950, #952) - `en-AU`: English/Australian (Default locale) (#946) - `en-IE`: English/Irish (#946) - `en-UK`: English/United Kingdom (#946) - `en-US`: English/United States (#946) - `es-ES`: Spanish. (#953) - `fr-FR`: French. (#962) - Port CI pipeline to PlatformIO (#936) **[Misc]** - Add DAIKIN128 & DAIKIN152 to `decodeToState()` (#982) - auto_analyse: Produce better code when leader is detected. (#977) - Coolix A/C improvements (#944) - A/C setRaw/getRaw/stateReset() cleanup. (#967) - Add documentation on how to use & support the i18n aspects of the library. - Make travis checks faster. (#957) - Translate README.md to french (#959) - Fixed Coolix kCoolixDefaultState (#941) - Improve generation of list of pio projects. (#940)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Oct 30, 2019
_v2.7.0 (20191030)_ **[Bug Fixes]** - auto_analyse: Fix > 64 bit send code generation. (#976) - auto_analyse: Fix missing arguments in generated code for send64+ (#972) - IRsendProntoDemo: Fix compile issue on ESP32 platform. (#938) - IRMQTTServer: Fix compile error when `MQTT_ENABLE` is false. (#933) **[Features]** - Add Hitachi 424 bit A/C support. (#975, #980, #981) - Experimental detailed support for `DAIKIN152` (#971) - Mitsubishi 112bit A/C support (#947, #968) - gc_decode: Adding Support for Decoding codes in raw code format (#963) - Refactor to use common routines/macros to handle bit manipulation. (#934) - Use centralised common strings. Saves ~1.5k of program space. (#946) - Add Internationalisation (i18n) / Locale support. (#946, #955, #966) - `de-CH`: Swiss German. (#949, #954) - `de-DE`: German. (#946, #950, #952) - `en-AU`: English/Australia (Default locale) (#946) - `en-IE`: English/Ireland (#946) - `en-UK`: English/United Kingdom (#946) - `en-US`: English/United States (#946) - `es-ES`: Spanish. (#953) - `fr-FR`: French. (#962) - Port CI pipeline to PlatformIO (#936) **[Misc]** - Add DAIKIN128 & DAIKIN152 to `decodeToState()` (#982) - auto_analyse: Produce better code when leader is detected. (#977) - Coolix A/C improvements (#944) - A/C setRaw/getRaw/stateReset() cleanup. (#967) - Add documentation on how to use & support the i18n aspects of the library. - Make travis checks faster. (#957) - Translate README.md to french (#959) - Fixed Coolix kCoolixDefaultState (#941) - Improve generation of list of pio projects. (#940)
|
FYI, the changes mention above have been included in the v2.7.0 release of the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new code should hopefully cover a new Mitsubishi protocol that is 112 bits long (hence 112). It currently implements most of the standard AC functions. The potential is there for Econo and SwingH settings. It also includes a few basic checks to see that things work properly.