Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BUG] Illegal Heap write in
rawbuf
when the capture has overflowed.
* Fix an issue where we write past the end of the capture buffer when it is full. Two options to fix this: 1. Extend all capture buffers by 1 entry. i.e. upto 4 bytes of extra unused heap and some FLASH/PROGMEM bytes. _or_ 2. Skip the memory write when we have overflowed. i.e. Possibly slightly more than 4 bytes of FLASH/PROGMEM used. - CPU overhead should be about the same. - Given heap & memory is a more critical resource than Flash/PROGMEM, opting for Option 2. TODO: Add unit tests to confirm this works and never happens again. Kudos to @davepl for reporting the issue and diagnosing the offending line of code. Fixes #1516
- Loading branch information