fixed bug in rmvDAG #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
it seems that the current version of rmvDAG samples from the error matrix when the sum of all edge weights is not larger than 0. I don't think this is what we want. As a minimal example, assume we have two nodes, X and Y, where the edge X -> Y is -0.5. The current rmvDAG function would sample from the error matrix instead of accounting for this negative effect.
I have fixed this by writing sum(abs(weightMatrix)) > 0 instead of sum(weightMatrix) > 0.
Cheers,
Fabian