Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARED linking for Geographiclib #624

Merged
merged 2 commits into from
Mar 22, 2021
Merged

SHARED linking for Geographiclib #624

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a4f3f6
SHARED linking for Geographiclib
AchmadFathoni Feb 21, 2021
a61b19a
remove GeographicLib specific linking option
AchmadFathoni Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ endif()

# Geographiclib installs FindGeographicLib.cmake to this non-standard location
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "/usr/share/cmake/geographiclib/")
find_package(GeographicLib REQUIRED COMPONENTS STATIC)
find_package(GeographicLib REQUIRED)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AGummyBear Was there any reason for the static linkage previously?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking was just that it would result in not needing to install GeographicLib as a dependency unless building, since I think most users are probably running this package as installed. I'm fine with the change to shared though. There was no technical reason to use static.


# Attempt to find Eigen using its own CMake module.
# If that fails, fall back to cmake_modules package.
Expand Down