Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala 3 Native and cleanup #376

Merged
merged 17 commits into from
May 20, 2022
Merged

Scala 3 Native and cleanup #376

merged 17 commits into from
May 20, 2022

Conversation

sideeffffect
Copy link

closes #373
closes #364
closes #353
closes #359

blocked on cquiroz/scala-java-locales#342

@sideeffffect sideeffffect changed the title Scala 3 Native and cleanup [WIP[ Scala 3 Native and cleanup May 9, 2022
@sideeffffect sideeffffect changed the title [WIP[ Scala 3 Native and cleanup [WIP] Scala 3 Native and cleanup May 9, 2022
@sideeffffect
Copy link
Author

Hi @lolgab !

[warn] Found a call to not defined static method Member(Top(java.time.Month),D9SEPTEMBERL15java.time.MonthEo). Static methods are generated since Scala Native 0.4.3, report this bug in the Scala Native issues. Call defined at file:/home/runner/work/scala-java-time/scala-java-time/tzdb/native/target/scala-2.13/src_managed/main/tzdb/tzdb_java.scala:2698:340
...
[error] Not found Member(Top(java.time.Month),D9SEPTEMBERL15java.time.MonthEo)
[error] 	at /home/runner/work/scala-java-time/scala-java-time/tests/native/target/scala-2.13/src_managed/test/org/threeten/bp/TestMonth.scala:251
...

Do you have any idea how to fix these issues? 🙏

@sideeffffect sideeffffect force-pushed the scala-3-native-cleanup branch from 85581b2 to 3eb873f Compare May 19, 2022 17:51
@sideeffffect sideeffffect reopened this May 19, 2022
@sideeffffect sideeffffect changed the title [WIP] Scala 3 Native and cleanup Scala 3 Native and cleanup May 19, 2022
@sideeffffect sideeffffect reopened this May 19, 2022
cquiroz
cquiroz approved these changes May 19, 2022
View reviewed changes
Copy link
Owner

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot

@sideeffffect
Copy link
Author

@cquiroz we can merge this! 🎉 Please make a new release after that 🙏

@cquiroz
Copy link
Owner

cquiroz commented May 20, 2022

Thanks a lot for getting this through

@cquiroz cquiroz merged commit c74766d into cquiroz:master May 20, 2022
@sideeffffect sideeffffect deleted the scala-3-native-cleanup branch May 20, 2022 00:25
@lolgab lolgab mentioned this pull request May 20, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sideeffffect @cquiroz