Using Jackson's XML reader instead of JAXB.unmarshal for ModelInfo files #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modelinfo data. QICore and UsCore are still broken.
IntelliJIdea can run a replace all with: ``` From: <typeInfo ([^>]*) xsi:type="ClassInfo"> To: <typeInfo xsi:type="ClassInfo" $1> ```
vitorpamplona
changed the title
This was referenced May 5, 2022
This was referenced May 19, 2022
brynrhodes
approved these changes
May 20, 2022
|
LGTM. Builds locally, all tests pass. |
|
Also, researched the performance implications and I didn't run performance metrics personally, but from what I can tell the Jackson reader should be more performant. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces JAXB with Jackson for loading ModelInfo files, making it suitable for use on Android. It fixes #640
Notice that:
1 - There were typos on the modelinfo files:
primaryCocdePathandprimaryCOdePath(Jackson XML is case sensitive)2 - There is a bug on Jackson's XML mapper that requires
xsi:typeto be the first property on XML elements with polymorphic nested objects.IntelliJIdea can run a replace all with: