Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceres-solver: update to v2.2.0-p0 and fix examples #703

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

NeroBurner
Copy link

Update examples using SuiteSparse, building with OpenBLAS per default, ant one testing with dynamic-LAPACK package.

On older GCC versions like 7.5 from Ubuntu 18.04 bionic fall back to older ceres-solver 2.1.0-p1 version, as 2.2.0 needs a fully C++17 compliant compiler.

Fix the CUDA=OFF option, as it was renamed to USE_CUDA. Still disable both.

Update examples using SuiteSparse, building with OpenBLAS per default,
ant one testing with dynamic-LAPACK package.

On older GCC versions like 7.5 from Ubuntu 18.04 bionic fall back to
older ceres-solver `2.1.0-p1` version, as `2.2.0` needs a fully C++17
compliant compiler.

- Ubuntu 18.04 disablement: ceres-solver/ceres-solver@40c1a7e
- C++17 requirement: ceres-solver/ceres-solver@1274743

Fix the `CUDA=OFF` option, as it was renamed to `USE_CUDA`. Still disable
both.
@NeroBurner
Copy link
Author

Eigen related fix moved to PR #704

@NeroBurner NeroBurner force-pushed the ceres-solver_v2.2.0-p0 branch from 5742878 to f0a0744 Compare October 25, 2023 15:34
@NeroBurner NeroBurner added the package:update Add a new version to an existing package label Oct 25, 2023
@NeroBurner NeroBurner requested a review from rbsheth October 25, 2023 15:35
@rbsheth rbsheth merged commit 3301b68 into master Oct 26, 2023
@rbsheth rbsheth deleted the ceres-solver_v2.2.0-p0 branch October 26, 2023 16:14
@NeroBurner
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:update Add a new version to an existing package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants