-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'CURL' to v8.4.0 #663
Conversation
seems to work as well as the previous version https://cpp-pm.github.io/hunter/#CURL nice clean commits, one for each dependency. I've not checked the previous implementation, but if your new one does the same thing then it looks very good |
There are probably things missing from it, but the old stuff was so confusing about what is required that I figured starting from here might make sense. Hopefully some other users of CURL in hunter can try it out. |
Had trouble with newer versions of cURL in Hunter in the past, hope this fixes it! |
I have un-drafted the CURL change in that case. I will then update the link here with the tag when it is ready. |
@rbsheth @NeroBurner : Anything we can do to move this along? i.e. get cpp-pm/curl#6 merged? |
Merged and released your cURL changes: https://github.com/cpp-pm/curl/releases/tag/v7.88.1-p0 |
2db2caf
to
69e3adf
Compare
69e3adf
to
6b3063f
Compare
Thanks, I have rebased, tested and updated this MR now |
I have put a PR in for the latest CURL too (since I am in the area) cpp-pm/curl#7 |
6b3063f
to
0bbd326
Compare
Thanks, this is now all ready on 8.4.0 |
step by step carefully. [Yes]
This required redoing the CMake integration in cpp-pm/curl#6