Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'CURL' to v8.4.0 #663

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Update 'CURL' to v8.4.0 #663

merged 2 commits into from
Oct 26, 2023

Conversation

hjmallon
Copy link

  • I've followed this guide
    step by step carefully. [Yes]

This required redoing the CMake integration in cpp-pm/curl#6

@hjmallon hjmallon marked this pull request as draft February 28, 2023 18:55
@hjmallon hjmallon changed the title Draft: Update 'CURL' to v7.88.1 Update 'CURL' to v7.88.1 Feb 28, 2023
@hjmallon hjmallon mentioned this pull request Feb 28, 2023
@NeroBurner
Copy link

seems to work as well as the previous version

https://cpp-pm.github.io/hunter/#CURL

curl hunter test matrix

nice clean commits, one for each dependency. I've not checked the previous implementation, but if your new one does the same thing then it looks very good

@hjmallon
Copy link
Author

hjmallon commented Feb 28, 2023

There are probably things missing from it, but the old stuff was so confusing about what is required that I figured starting from here might make sense. Hopefully some other users of CURL in hunter can try it out.

@rbsheth
Copy link
Member

rbsheth commented Feb 28, 2023

Had trouble with newer versions of cURL in Hunter in the past, hope this fixes it!

@hjmallon
Copy link
Author

hjmallon commented Mar 9, 2023

I have un-drafted the CURL change in that case. I will then update the link here with the tag when it is ready.

@hjmallon
Copy link
Author

@rbsheth @NeroBurner : Anything we can do to move this along? i.e. get cpp-pm/curl#6 merged?

@rbsheth
Copy link
Member

rbsheth commented Oct 26, 2023

Merged and released your cURL changes: https://github.com/cpp-pm/curl/releases/tag/v7.88.1-p0

@hjmallon hjmallon marked this pull request as ready for review October 26, 2023 16:26
@hjmallon
Copy link
Author

Merged and released your cURL changes: https://github.com/cpp-pm/curl/releases/tag/v7.88.1-p0

Thanks, I have rebased, tested and updated this MR now

@hjmallon
Copy link
Author

I have put a PR in for the latest CURL too (since I am in the area) cpp-pm/curl#7

@rbsheth
Copy link
Member

rbsheth commented Oct 26, 2023

@hjmallon hjmallon changed the title Update 'CURL' to v7.88.1 Update 'CURL' to v8.4.0 Oct 26, 2023
@hjmallon
Copy link
Author

Thanks, this is now all ready on 8.4.0

@NeroBurner NeroBurner merged commit f1ecb94 into cpp-pm:master Oct 26, 2023
@NeroBurner NeroBurner added the package:update Add a new version to an existing package label Oct 27, 2023
@NeroBurner
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:update Add a new version to an existing package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants