prepare for rust pkg tests #42

2bndy5 · 2024-09-25T03:23:26Z

No description provided.

github-actions · 2024-09-27T00:31:02Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v17.0.4) reports: 2 file(s) not formatted

src/demo.cpp
src/demo.hpp

clang-tidy (v17.0.4) reports: 2 concern(s)

src/demo.cpp

src/demo.cpp:11:13: warning: [readability-braces-around-statements]

statement should be inside braces
```
   11 |     for (;;) break;
      |             ^      
      |              {
```

src/demo.hpp

src/demo.hpp:10:11: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function

   10 |     void *not_useful(char *str){
      |     ~~~~~~^                    
      |     auto                        -> void *

Have any feedback or feature suggestions? Share it here.

outdated suggestion

github-actions

Cpp-linter Review

Used clang-format v17.0.4

Click here for the full clang-format patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 6d17b23..0c1db60 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -11 +11,2 @@ int main()
-    for (;;) break;
+    for (;;)
+        break;
diff --git a/src/demo.hpp b/src/demo.hpp
index c9f634c..eb53b5f 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -10,4 +10,5 @@ class Dummy {
-    void *not_useful(char *str){
-        useless = str;
-        return 0;
-    }
+        void* not_useful(char* str)
+        {
+            useless = str;
+            return 0;
+        }

Used clang-tidy v17.0.4

Click here for the full clang-tidy patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 6d17b23..9cf93c0 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -11 +11,3 @@ int main()
-    for (;;) break;
+    for (;;) {
+        break;
+    }
diff --git a/src/demo.hpp b/src/demo.hpp
index c9f634c..439de24 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -10,4 +10,5 @@ class Dummy {
-    void *not_useful(char *str){
-        useless = str;
-        return 0;
-    }
+        auto not_useful(char* str) -> void*
+        {
+            useless = str;
+            return 0;
+        }

Have any feedback or feature suggestions? Share it here.

src/demo.cpp

src/demo.hpp

outdated suggestion

github-actions

Cpp-linter Review

Used clang-format v17.0.6

Only 2 out of 7 clang-format concerns fit within this pull request's diff.

Click here for the full clang-format patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 6d17b23..8bbf972 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -3 +2,0 @@
-#include <cstdio>
@@ -4,0 +4 @@
+#include <cstdio>
@@ -11 +11,2 @@ int main()
-    for (;;) break;
+    for (;;)
+        break;
diff --git a/src/demo.hpp b/src/demo.hpp
index c9f634c..c04085d 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -3,2 +2,0 @@
-
-
@@ -9,2 +7,3 @@ class Dummy {
-    public:
-    void *not_useful(char *str){
+public:
+    void* not_useful(char* str)
+    {
@@ -16,23 +15 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {
@@ -40 +16,0 @@ struct LongDiff
-

Used clang-tidy v17.0.6

Only 4 out of 6 clang-tidy concerns fit within this pull request's diff.

Click here for the full clang-tidy patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 6d17b23..e6609ce 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -2 +1,0 @@
-#include "demo.hpp"
@@ -7 +6 @@
-size_t dummyFunc(size_t i) { return i; }
+auto dummyFunc(size_t i) -> size_t { return i; }
@@ -9 +8 @@ size_t dummyFunc(size_t i) { return i; }
-int main()
+auto main() -> int
@@ -11 +10,3 @@ int main()
-    for (;;) break;
+    for (;;) {
+        break;
+    }
diff --git a/src/demo.hpp b/src/demo.hpp
index c9f634c..d4346e3 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -10,4 +10,5 @@ class Dummy {
-    void *not_useful(char *str){
-        useless = str;
-        return 0;
-    }
+        auto not_useful(char* str) -> void*
+        {
+            useless = str;
+            return nullptr;
+        }

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-11-27T11:05:28Z

src/demo.cpp

@@ -8,8 +8,7 @@ size_t dummyFunc(size_t i) { return i; }

 int main()
 {
-    for (;;)
-        break;
+    for (;;) break;


clang-format suggestions

Suggested change

for (;;) break;

for (;;)

break;

clang-tidy diagnostic(s)

readability-braces-around-statements

Suggested change

for (;;) break;

for (;;) {

break;

}

github-actions · 2024-11-27T11:05:29Z

src/demo.cpp

@@ -8,8 +8,7 @@ size_t dummyFunc(size_t i) { return i; }

 int main()


clang-tidy diagnostic(s)

modernize-use-trailing-return-type

Suggested change

int main()

auto main() -> int

github-actions · 2024-11-27T11:05:29Z

src/demo.cpp

@@ -8,8 +8,7 @@ size_t dummyFunc(size_t i) { return i; }

 int main()
 {
-    for (;;)
-        break;
+    for (;;) break;

    printf("Hello world!\n");


clang-tidy diagnostic

src/demo.cpp:13:5 warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions

13 | printf("Hello world!\n"); | ^

github-actions · 2024-11-27T11:05:29Z

src/demo.hpp

    public:
-    void *not_usefull(char *str){
+    void *not_useful(char *str){


clang-format suggestions

Suggested change

public:

void *not_usefull(char *str){

void *not_useful(char *str){

public:

void* not_useful(char* str)

{

github-actions · 2024-11-27T11:05:29Z

src/demo.hpp

+    void *not_useful(char *str){
        useless = str;
        return 0;
    }


clang-tidy diagnostic(s)

modernize-use-trailing-return-type

modernize-use-nullptr

Suggested change

void *not_useful(char *str){

useless = str;

return 0;

}

auto not_useful(char* str) -> void*

{

useless = str;

return nullptr;

}

outdated suggestion

github-actions

Cpp-linter Review

Used clang-format v17.0.4

Only 2 out of 7 clang-format concerns fit within this pull request's diff.

Click here for the full clang-format patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 6d17b23..8bbf972 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -3 +2,0 @@
-#include <cstdio>
@@ -4,0 +4 @@
+#include <cstdio>
@@ -11 +11,2 @@ int main()
-    for (;;) break;
+    for (;;)
+        break;
diff --git a/src/demo.hpp b/src/demo.hpp
index c9f634c..c04085d 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -3,2 +2,0 @@
-
-
@@ -9,2 +7,3 @@ class Dummy {
-    public:
-    void *not_useful(char *str){
+public:
+    void* not_useful(char* str)
+    {
@@ -16,23 +15 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {
@@ -40 +16,0 @@ struct LongDiff
-

Used clang-tidy v17.0.4

Only 4 out of 6 clang-tidy concerns fit within this pull request's diff.

Click here for the full clang-tidy patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 6d17b23..e6609ce 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -2 +1,0 @@
-#include "demo.hpp"
@@ -7 +6 @@
-size_t dummyFunc(size_t i) { return i; }
+auto dummyFunc(size_t i) -> size_t { return i; }
@@ -9 +8 @@ size_t dummyFunc(size_t i) { return i; }
-int main()
+auto main() -> int
@@ -11 +10,3 @@ int main()
-    for (;;) break;
+    for (;;) {
+        break;
+    }
diff --git a/src/demo.hpp b/src/demo.hpp
index c9f634c..d4346e3 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -10,4 +10,5 @@ class Dummy {
-    void *not_useful(char *str){
-        useless = str;
-        return 0;
-    }
+        auto not_useful(char* str) -> void*
+        {
+            useless = str;
+            return nullptr;
+        }

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-11-27T11:05:48Z

src/demo.cpp


 int main()
 {
-    for (;;)
-        break;
+    for (;;) break;


clang-format suggestions

Suggested change

for (;;) break;

for (;;)

break;

clang-tidy diagnostic(s)

readability-braces-around-statements

Suggested change

for (;;) break;

for (;;) {

break;

}

github-actions · 2024-11-27T11:05:48Z

src/demo.cpp

 #include <cstddef>

 // using size_t from cstddef
 size_t dummyFunc(size_t i) { return i; }

 int main()


clang-tidy diagnostic(s)

modernize-use-trailing-return-type

Suggested change

int main()

auto main() -> int

github-actions · 2024-11-27T11:05:48Z

src/demo.cpp


 int main()
 {
-    for (;;)
-        break;
+    for (;;) break;

    printf("Hello world!\n");


clang-tidy diagnostic

src/demo.cpp:13:5 warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions

13 | printf("Hello world!\n"); | ^

github-actions · 2024-11-27T11:05:48Z

src/demo.hpp

    public:
-    void *not_usefull(char *str){
+    void *not_useful(char *str){


clang-format suggestions

Suggested change

public:

void *not_usefull(char *str){

void *not_useful(char *str){

public:

void* not_useful(char* str)

{

github-actions · 2024-11-27T11:05:48Z

src/demo.hpp

+    void *not_useful(char *str){
        useless = str;
        return 0;
    }


clang-tidy diagnostic(s)

modernize-use-trailing-return-type

modernize-use-nullptr

Suggested change

void *not_useful(char *str){

useless = str;

return 0;

}

auto not_useful(char* str) -> void*

{

useless = str;

return nullptr;

}

outdated suggestion

github-actions

Cpp-linter Review

Used clang-format v17.0.4

Click here for the full clang-format patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 6d17b23..0c1db60 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -11 +11,2 @@ int main()
-    for (;;) break;
+    for (;;)
+        break;
diff --git a/src/demo.hpp b/src/demo.hpp
index c9f634c..eb53b5f 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -10,4 +10,5 @@ class Dummy {
-    void *not_useful(char *str){
-        useless = str;
-        return 0;
-    }
+        void* not_useful(char* str)
+        {
+            useless = str;
+            return 0;
+        }

Used clang-tidy v17.0.4

Click here for the full clang-tidy patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 6d17b23..9cf93c0 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -11 +11,3 @@ int main()
-    for (;;) break;
+    for (;;) {
+        break;
+    }
diff --git a/src/demo.hpp b/src/demo.hpp
index c9f634c..439de24 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -10,4 +10,5 @@ class Dummy {
-    void *not_useful(char *str){
-        useless = str;
-        return 0;
-    }
+        auto not_useful(char* str) -> void*
+        {
+            useless = str;
+            return 0;
+        }

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-12-12T15:37:32Z

src/demo.cpp

@@ -8,8 +8,7 @@ size_t dummyFunc(size_t i) { return i; }

 int main()
 {
-    for (;;)
-        break;
+    for (;;) break;


clang-format suggestions

Suggested change

for (;;) break;

for (;;)

break;

clang-tidy diagnostic(s)

readability-braces-around-statements

Suggested change

for (;;) break;

for (;;) {

break;

}

github-actions · 2024-12-12T15:37:32Z

src/demo.hpp

+    void *not_useful(char *str){
        useless = str;
        return 0;
    }


clang-format suggestions

Suggested change

void *not_useful(char *str){

useless = str;

return 0;

}

void* not_useful(char* str)

{

useless = str;

return 0;

}

clang-tidy diagnostic(s)

modernize-use-trailing-return-type

Suggested change

void *not_useful(char *str){

useless = str;

return 0;

}

auto not_useful(char* str) -> void*

{

useless = str;

return 0;

}

2bndy5 · 2024-12-12T15:41:06Z

keeping branch but closing PR. Going to open a new one later...

2bndy5 added 2 commits September 24, 2024 20:22

prepare for rust pkg tests

a9f1753

pin to 2.0.0rc4

fd0c510

2bndy5 added 2 commits September 26, 2024 17:41

build from feature branch

09938a8

enable PR reviews

38a5304

2bndy5 force-pushed the test-rust branch from 224c6c8 to 38a5304 Compare September 27, 2024 00:43

add explicit permission

eae925c

This comment was marked as duplicate.

Sign in to view

add contents permission to write

89b3bad

This comment was marked as duplicate.

Sign in to view

switch to main branch

1be32b6

This comment was marked as duplicate.

Sign in to view

enable color logs

c61ad92

This comment was marked as outdated.

Sign in to view

2bndy5 force-pushed the test-rust branch 2 times, most recently from 44f18fb to 4cb2600 Compare November 24, 2024 11:27

This comment was marked as outdated.

Sign in to view

switch to 2.0.0rc8 dist

574be43

2bndy5 force-pushed the test-rust branch from 4cb2600 to 574be43 Compare November 24, 2024 12:14

github-actions bot previously requested changes Nov 24, 2024

View reviewed changes

src/demo.cpp Show resolved Hide resolved

src/demo.hpp Show resolved Hide resolved

use pre-release as action

0b4a40f

2bndy5 force-pushed the test-rust branch from af1e068 to 0b4a40f Compare November 26, 2024 21:50

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

2bndy5 mentioned this pull request Nov 27, 2024

fix: clang-tidy diagnostic comments in PR review cpp-linter/cpp-linter-rs#77

Merged

2 tasks

github-actions bot previously requested changes Nov 27, 2024

View reviewed changes

This comment was marked as duplicate.

Sign in to view

switch back to v2.0.0rc11

f46a3a6

github-actions bot requested changes Dec 12, 2024

View reviewed changes

2bndy5 closed this Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

prepare for rust pkg tests #42

prepare for rust pkg tests #42

2bndy5 commented Sep 25, 2024

github-actions bot commented Sep 27, 2024 •

edited

Loading

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot left a comment

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as outdated.

github-actions bot left a comment

github-actions bot Nov 27, 2024

github-actions bot Nov 27, 2024

github-actions bot Nov 27, 2024

github-actions bot Nov 27, 2024

github-actions bot Nov 27, 2024

github-actions bot left a comment

github-actions bot Nov 27, 2024

github-actions bot Nov 27, 2024

github-actions bot Nov 27, 2024

github-actions bot Nov 27, 2024

github-actions bot Nov 27, 2024

This comment was marked as duplicate.

github-actions bot left a comment

github-actions bot Dec 12, 2024

github-actions bot Dec 12, 2024

2bndy5 commented Dec 12, 2024

		@@ -8,8 +8,7 @@ size_t dummyFunc(size_t i) { return i; }

		int main()

prepare for rust pkg tests #42

prepare for rust pkg tests #42

Conversation

2bndy5 commented Sep 25, 2024

github-actions bot commented Sep 27, 2024 • edited Loading

Cpp-Linter Report ⚠️

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-format v17.0.4

Used clang-tidy v17.0.4

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as outdated.

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-format v17.0.6

Used clang-tidy v17.0.6

github-actions bot Nov 27, 2024

Choose a reason for hiding this comment

clang-format suggestions

clang-tidy diagnostic(s)

github-actions bot Nov 27, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic(s)

github-actions bot Nov 27, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot Nov 27, 2024

Choose a reason for hiding this comment

clang-format suggestions

github-actions bot Nov 27, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic(s)

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-format v17.0.4

Used clang-tidy v17.0.4

github-actions bot Nov 27, 2024

Choose a reason for hiding this comment

clang-format suggestions

clang-tidy diagnostic(s)

github-actions bot Nov 27, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic(s)

github-actions bot Nov 27, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot Nov 27, 2024

Choose a reason for hiding this comment

clang-format suggestions

github-actions bot Nov 27, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic(s)

This comment was marked as duplicate.

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-format v17.0.4

Used clang-tidy v17.0.4

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

clang-format suggestions

clang-tidy diagnostic(s)

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

clang-format suggestions

clang-tidy diagnostic(s)

github-actions bot commented Sep 27, 2024 •

edited

Loading