Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Update multiple Conan dependencies. #96

Closed
wants to merge 2 commits into from

Conversation

ddalcino
Copy link
Collaborator

@ddalcino ddalcino commented Oct 8, 2020

The fmt update is meant to address a bug reported in #81.

Note that spdlog/1.8.0 is dependent on fmt/7.0.3.

Related to #65: specific dependency versions supersede #65, but this does not replace the move to a separate file. Unless these dependencies are moved to a separate file, the process of bumping these dependencies cannot be easily automated, and PRs like this one will always be necessary to keep packages up to date.

The `fmt` update is meant to address a bug reported in cpp-best-practices#81.

Note that `spdlog/1.8.0` is dependent on `fmt/7.0.3`.

Related to cpp-best-practices#65: specific dependency versions supersede cpp-best-practices#65, but this
does not supplant the move to a separate file. Unless these
dependencies are moved to a separate file, the process of bumping these
dependencies cannot be easily automated. PRs like this one will be
necessary to keep packages up to date.
@ddalcino
Copy link
Collaborator Author

ddalcino commented Oct 8, 2020

Please note: Although the Travis and Appveyor builds of this are working just fine, the Github Actions workflow for this is failing: https://github.com/ddalcino/cpp_starter_project/runs/1227289080

The error message is something to do with a conditional in fmt/core.h with duplicate branches, caused by this line in src/main.cpp:44:41:

fmt::print("Hello, from {}\n", "{fmt}");

While the Travis builds use gcc-9, the Github Action build uses gcc-7. This is the only significant difference I can see between the working Travis build and the failing Github Action. I initially suspected that fmt/7.0.3 expects a newer compiler, but if you check fmt's CI build, they use g++-6, g++-8, clang-4, and clang-6 without any problem. I'm not sure what's going on here.

EDIT: The Github Actions workflow is working now: https://github.com/ddalcino/cpp_starter_project/actions/runs/494994408

@ddalcino ddalcino closed this Jan 19, 2021
@ddalcino ddalcino deleted the bump-deps branch March 1, 2021 19:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant