Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index <cstarg> macros #7615

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AlisdairM
Copy link
Contributor

Following Jens's suggestion, adding the improved indexing of the macros more widely used in the standard as separate PRs.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good.

The commit descriptions need work:

The first commit should use the usual phrasing "Improve indexing for macros"
The second commit uses backticks, the third one uses usual single quotes. Please consistencify. (no that's not a word)

@AlisdairM AlisdairM force-pushed the index_cstarg_macros branch from d5f582c to a152372 Compare February 4, 2025 22:04
@AlisdairM
Copy link
Contributor Author

Cleaned up the final commit message, but the first commit is intentional as it performs an indexing cleanup on the va_list typedef as well as the macros, treating the header as a whole, so I did not want to call it out as just a macro indexing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants