Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Package Access Modifier #249

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Use Package Access Modifier #249

merged 1 commit into from
Feb 18, 2024

Conversation

cpisciotta
Copy link
Owner

@cpisciotta cpisciotta commented Feb 6, 2024

Downgrade existing types to use the package access level modifier. In a future PR, introduce a public type for XCBeautifyLib consumers.

@cpisciotta cpisciotta linked an issue Feb 6, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (385a721) 86.27% compared to head (1d39b04) 86.26%.

Files Patch % Lines
Sources/XcbeautifyLib/Parser.swift 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   86.27%   86.26%   -0.01%     
==========================================
  Files          13       13              
  Lines        1537     1536       -1     
==========================================
- Hits         1326     1325       -1     
  Misses        211      211              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpisciotta cpisciotta force-pushed the PackageAccessModifier branch from 8558ca8 to 7f02153 Compare February 8, 2024 03:48
@cpisciotta cpisciotta force-pushed the PackageAccessModifier branch 2 times, most recently from be44a3a to 860b181 Compare February 18, 2024 03:16
@cpisciotta cpisciotta force-pushed the PackageAccessModifier branch from 860b181 to 1d39b04 Compare February 18, 2024 04:34
@cpisciotta cpisciotta marked this pull request as ready for review February 18, 2024 04:45
@cpisciotta cpisciotta merged commit 928abea into main Feb 18, 2024
6 of 7 checks passed
@cpisciotta cpisciotta deleted the PackageAccessModifier branch February 18, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Public Access Modifiers with Package Access Modifiers
1 participant