Prevent Duplicate CaptureGroup Registrations (#370)

cpisciotta · Feb 10, 2025 · 577fc8d · 577fc8d
1 parent 309466f
commit 577fc8d
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 5 deletions.
diff --git a/Sources/XcbeautifyLib/Parser.swift b/Sources/XcbeautifyLib/Parser.swift
@@ -104,11 +104,6 @@ package final class Parser {
         TestSuiteAllTestsPassedCaptureGroup.self,
         TestSuiteAllTestsFailedCaptureGroup.self,
         TestingStartedCaptureGroup.self,
-        ExecutedWithoutSkippedCaptureGroup.self,
-        ExecutedWithSkippedCaptureGroup.self,
-        TestSuiteAllTestsPassedCaptureGroup.self,
-        TestSuiteAllTestsFailedCaptureGroup.self,
-        TestingStartedCaptureGroup.self,
         SwiftEmitModuleCaptureGroup.self,
         SwiftMergeGeneratedHeadersCaptureGroup.self,
         SwiftTestingRunStartedCaptureGroup.self,
@@ -133,6 +128,12 @@ package final class Parser {
         NoteCaptureGroup.self,
     ]
 
+    #if DEBUG
+    func __for_test__captureGroupTypes() -> [any CaptureGroup.Type] {
+        captureGroupTypes
+    }
+    #endif
+
     // MARK: - Init
 
     package init() { }

diff --git a/Tests/XcbeautifyLibTests/UniqueCaptureGroupTests.swift b/Tests/XcbeautifyLibTests/UniqueCaptureGroupTests.swift
@@ -0,0 +1,34 @@
+//
+//  UniqueCaptureGroupTests.swift
+//  xcbeautify
+//
+//  Created by Charles Pisciotta on 2/9/25.
+//
+
+import XCTest
+@testable import XcbeautifyLib
+
+final class UniqueCaptureGroupTests: XCTestCase {
+    private let captureGroupTypes = Parser().__for_test__captureGroupTypes()
+
+    #if os(macOS)
+    func testUniqueCaptureGroupRegistrations() {
+        var seen = [any CaptureGroup.Type]()
+        var duplicates = [any CaptureGroup.Type]()
+
+        for type in captureGroupTypes {
+            if seen.contains(where: { $0 == type }) {
+                duplicates.append(type)
+            } else {
+                seen.append(type)
+            }
+        }
+
+        XCTAssertEqual(
+            duplicates.count,
+            0,
+            "Found the following duplicate CaptureGroup registration(s): \(ListFormatter.localizedString(byJoining: duplicates.map(String.init(describing:))))"
+        )
+    }
+    #endif
+}