-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Health 12.0.0 #1117
Merged
Merged
Health 12.0.0 #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore sdkman env
…hrow error on WRITE
Health 12/example update
Health data query to use HKStatisticsCollectionQuery instead of HKStatisticsQuery
Iarata/health-12 base branch
When deleting entries on iOS a compound predicate is used to limit the query to entries the calling app has created. Otherwise the call fails is the sample contains entries from other apps.
[Health] Deleting entries in iOS only selects own entries To reproduce the issue: Add data to the iOS Health using the "Add Data" button in example app, and try to delete using the "Delete Data" button. The steps, for example, will always be there and won't be deleted.
Health 12/1104 - iOS delete not deleting own
…d permission_handler to ^11.3.1
Health 12/1092 update dependencies
[Health] Fix NullPointerException when reading NUTRITION
…nderwaterDiving workout in iOS
…ving Add support for WaterTemperature and UnderwaterDepth data types and UnderwaterDiving workout in iOS
# Conflicts: # packages/health/example/ios/Runner.xcodeproj/project.pbxproj
#1078 Health 12/1097 Lean Body Mass Type
[Health] Updated device_info_plus version dependency
…-info Health 12/1095 update dependencies versions
[Health] fixed hasPermissoins call for iOS
Health 12/1091 iOS hasPermission
[health] Remove automatically added workout permissions
… for WORKOUT data type
…orkout-permissions Health 12/1055 remove auto workout permissions
Fix `HealthDataType was not aligned correctly` when adding SLEEP_LIGHT data
…pendency injection for DeviceInfoPlugin
[Health] Register WorkoutHealthValue
Health 12/1052 Register `WorkoutHealthValue`
feat: refactor `Health` class to remove singleton pattern and enable dependency injection for `DeviceInfoPlugin`
bardram
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Added some documentation in places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
health
plugin by removing thesingleton
pattern.DeviceInfoPlugin
:Health
class is no longer a singleton.Health()
factory constructor is removed.Health
class now accepts an (optional)DeviceInfoPlugin
dependency through its constructor, this change was introduced to provide easy mocking of theDeviceInfo
class during unit tests.Health
class MUST be initialized correctly as a global instance.Health
class as a global instance (i.e. do not callHealth()
every time but rather define an instancefinal health = Health();
).DISTANCE_DELTA
andTOTAL_CALORIES_BURNED
data types when requesting permission forWORKOUT
health data type.WORKOUT
s that require above permissions, now those need to be requested manually.LEAN_BODY_MASS
data type - Closes #1078 - Closes #1097LEAN_BODY_MASS
:WATER_TEMPERATURE
andUNDERWATER_DEPTH
health values - Closes #1096Underwater Diving
workout - Closes #1096SLEEP_LIGHT
type was not aligned correctly - Closes #1086intl
to ^0.20.1 - Fix #1092device_info_plus
to ^11.2.0permission_handler
to ^11.3.1