test: Fix tests failing intermittently on CI #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `moveFrom` method of our file and directory builders should not generate a `Metadata` object with an `updated_at` attribute different from the one of the `Metadata` object passed as argument (i.e. the "old" metadata, before the move occured) since moves on filesystems do not update the `mtime` attribute. Therefore the builder will keep any existing `updated_at` attribute when calling `moveFrom` and set a new date otherwise.
taratatach
force-pushed
the
test/fix-flaky-tests
branch
from
cdd55c0 to
f421161
Compare
taratatach
changed the title
taratatach
changed the title
taratatach
changed the title
These tests were intermittently failing due to slight update time differences which can be traced back to an invalid setup of the moved document metadata.
taratatach
force-pushed
the
test/fix-flaky-tests
branch
from
f421161 to
42a9f34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the following boxes are checked: