ci: Upgrade github actions macOS runner #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
changed the title
taratatach
force-pushed
the
ci/upgrade-macos-runner
branch
5 times, most recently
from
fd48919 to
18d7c91
Compare
taratatach
force-pushed
the
ci/upgrade-macos-runner
branch
23 times, most recently
from
2c0b511 to
76f8b91
Compare
taratatach
force-pushed
the
ci/upgrade-macos-runner
branch
21 times, most recently
from
3b8d2ff to
59ecabc
Compare
The `macos-10.15` runner is depecrated since 5/31/22 and will be unsupported by 12/1/22 (see actions/runner-images#5583). We did not upgrade before because the `macos-11` runner does not provide VirtualBox which we need to create an Ext filesystem for `cozy-stack` (see actions/runner-images#4010 for more details on previous attempts to add it to `macos-11`) and it was not yet available in the `macos-12` runner. It's now available in `macos-12` (see actions/runner-images#5594) so we can upgrade to `macos-12`.
This is the latest version of the v23.x major version, including a fix to the macOS `dmg` generation, introduced in v23.0.6 (see electron-userland/electron-builder#6789), that should allow us to build on Github Actions again.
This runtime option disables the chromium sandbox. It was added as a default option in `electron-builder` v22.10.3 (see electron-userland/electron-builder#4496) because the required kernel privileges might not be available on the user's computer (e.g. in Debian). However, these privileges might be available on some computers and the sandbox should be used in this case. Thankfully, `electron-builder` v22.14.8 makes this optional when using the build option `executableArgs` (see electron-userland/electron-builder#6429). Since we don't have any arguments to pass to Cozy Desktop, we'll just add an empty argument to the list to prevent the use of `--no-sandbox` in the Desktop entry. We'll still add the option ourselves when necesary (see ./build/launcher-script.sh`).
For tests to pass on macOS we need to have a Cozy storage with file names that are case and normalization sensitive, like a production Cozy storage would. We used to have a linux VM with an ext4 volume mounted via sshfs but we couldn't get a working connection to the VM on macOS 12 Github Actions runners. The solution we found to this problem was to setup a remote OpenStack Swift container that our test cozy-stack can use. This is even closer to our production setup than it was before.
taratatach
force-pushed
the
ci/upgrade-macos-runner
branch
from
5ee52f7 to
d9334bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
macos-10.15runner is deprecated since 5/31/22 and will beunsupported by 12/1/22 (see
actions/runner-images#5583).
We did not upgrade before because the
macos-11runner does notprovide VirtualBox which we need to create an Ext filesystem for
cozy-stack(seeactions/runner-images#4010 for more details on
previous attempts to add it to
macos-11)and it was not yet available in the
macos-12runner.Please make sure the following boxes are checked: