Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description filter component does not correctly apply chosen filters fix #699

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Description filter component does not correctly apply chosen filters fix #699

merged 1 commit into from
Feb 4, 2024

Conversation

jacobyarborough
Copy link
Contributor

@jacobyarborough jacobyarborough commented Feb 1, 2024 •
edited
Loading

  • Modifies the filter_name_for method so that the remove_filter_link HTML tag includes the filter name and value instead of just the filter name.

Before example:
Screenshot of the descriptions page before fix. There are chosen filters for status: ready to approve and metum: alt. Once the filters are chosen and the new results are displayed, the active filters icons only display Metum id in and Status in leaving off the values. The filter icons are highlighted by a red rectangle in the screenshot.

After fix example:
Screenshot of the descriptions page after fix. There are chosen filters for 'status: ready to approve' and 'metum: alt'. Once the filters are chosen and the new results are displayed, the active filters icons display 'Metum id in: 1' and 'Status in: Ready to approve'. The filter icons are highlighted by a red rectangle in the screenshot.

@jacobyarborough jacobyarborough linked an issue Feb 1, 2024 that may be closed by this pull request
Description filter component does not correctly apply chosen filters #681
Closed
@jacobyarborough jacobyarborough marked this pull request as ready for review February 1, 2024 15:27
subelsky
subelsky approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@subelsky subelsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobyarborough jacobyarborough merged commit 24000f4 into staging Feb 4, 2024
1 check passed
@jacobyarborough jacobyarborough deleted the 681-description-filter-component-does-not-correctly-apply-chosen-filters branch February 4, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subelsky subelsky subelsky approved these changes

@SamuelHShaw SamuelHShaw Awaiting requested review from SamuelHShaw

Assignees

@leibylucw leibylucw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Description filter component does not correctly apply chosen filters
3 participants
@jacobyarborough @subelsky @leibylucw