Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list for custom partner fees #509

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

harisang
Copy link
Contributor

@harisang harisang commented Feb 6, 2025

This PR allows to set different percents for the partner fee cut, depending on the partner. Up till now, there was only one partner address that could have a custom fee

@harisang harisang requested a review from fhenneke February 6, 2025 16:48
@harisang harisang marked this pull request as draft February 7, 2025 07:43
@harisang
Copy link
Contributor Author

harisang commented Feb 7, 2025

Marking as draft as i need to fix the tests. So no need for a review yet.

@harisang harisang marked this pull request as ready for review February 7, 2025 09:55
Copy link
Collaborator

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The code is way more versatile but the complexity of the implementation stayed roughly the same.

@harisang harisang merged commit 72f0abb into main Feb 10, 2025
6 checks passed
@harisang harisang deleted the add_configurable_partner_fee_tax_list branch February 10, 2025 10:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants