This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Handle appData errors #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 5658356984
💛 - Coveralls |
|
@nenadV91 pls review and let me know if all good |
nenadV91
reviewed
Jul 25, 2023
| textToCopy={fullAppDataPrettified} | ||
| contentsToDisplay={<pre className="json-formatter">{fullAppDataPrettified}</pre>} | ||
| /> | ||
| <p>This content is for illustration porpouses, see below.</p> |
There was a problem hiding this comment.
Small typo here porpouses
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #560
Handles the errors when generating the app-data CID/HEX
This is how it looks when the codes can be generated (valid input)
This is when you add something illegal in the JSON:
Bonus
Adds the latest app-data LIB version, which solves a concurrency issue that was braking the app (not loading the CID/hex on the first load)
cowprotocol/app-data#33
To Test
asdfghinstead of an address)