This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Remove upload to IPFS #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 5588753648
💛 - Coveralls |
shoom3301
approved these changes
Jul 18, 2023
|
Hey @anxolin , maybe we should disable 'Decode' tab for now as well? |
|
@elena-zh that for old docs it works, and for the new ones is still nice we get the IPFS CID (even if it doesn't work) |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the UPLOAD to IPFS part from the app-data.
For now we don't have a way to do this. Pinata don't allow it, we could add it back in the future if we use our own backend 9likely we will get an endpoint for this)
This Pr should be reverted in the future, and maybe adapted to upload the file.
To Test
Just notice is gone if you generate the
appData, you don't see the form any more.