Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Hide link to IPFS for new app-datas #557

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Hide link to IPFS for new app-datas #557

merged 3 commits into from
Jul 18, 2023

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Jul 18, 2023

Summary

Workaround for the issue we get when accessing the IPFS file related to orders (404 issue)

The backend has not published yet the documents, so we hide the link until we can show it: https://cowservices.slack.com/archives/C0375NV72SC/p1689618027267289

We can see the content of the JSON though, its just not in IPFS

To Test

  • Test one of the new app-data: search for order 0x60e2dd0aca15d6f1c604e35b96f406393aff563d01202eec8bd73db397352aec79063d9173c09887d536924e2f6eadbabac099f564ad372e --> should be not a link
image
  • Test one of the old, it should work as before 0xf547efc5f3f846d0a00ef5346570a8b24d12867f514827d7c9ff26e49584550c8654d1136f2a760ba3e1c9e131cb9ad217921b5264b5c8c7
image image

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 2:38pm

@anxolin anxolin changed the title Set version to v1.0.0 for app-data Hide link to IPFS for new app-datas Jul 18, 2023
@github-actions
Copy link

github-actions bot commented Jul 18, 2023

Pull Request Test Coverage Report for Build 5588837981

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.69%

Totals Coverage Status
Change from base Build 5588412838: 0.0%
Covered Lines: 877
Relevant Lines: 1236

💛 - Coveralls

@elena-zh
Copy link

Hey @anxolin , thank you for the fix!
I noticed that copy button copies the link that is not working. Can we copy here a hash only or should we leave it as it is for now?
image

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@anxolin anxolin merged commit 7afa539 into develop Jul 18, 2023
@alfetopito alfetopito deleted the hide-ipfs-link branch July 24, 2023 14:50
@nenadV91 nenadV91 mentioned this pull request Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants