This repository was archived by the owner on Feb 2, 2024. It is now read-only.
chore: show fullAppData if available #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 5545557164
💛 - Coveralls |
alfetopito
reviewed
Jul 13, 2023
| const decodedAppData = JSON.parse(fullAppData) | ||
| return { decodedAppData, isError: false } | ||
| } catch (error) { | ||
| console.error('Error parsing fullAppData from the API', { fullAppData }, error) |
There was a problem hiding this comment.
Shouldn't this branch also return isError: true ?
alfetopito
approved these changes
Jul 13, 2023
elena-zh
approved these changes
Jul 14, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Companion PR for cowprotocol/cowswap#2838 of CoW Swap, and cowprotocol/cow-sdk#128 of the SDK
This PR shows the appData when the backend provides it.
Technical notes
It doesn't try to get it from IPFS, directly, if available it uses the one returned by the API
Not included
There's another way to derive the IPFS link now from the appData, however this doesn't work for now until the backend uploads the docs to IPFS.
Once they do we will need to come back and review the logic for generating the IPFS URL, now it will take you to a 404. Leaving this for another PR.
To Test
Background
This is part of the changes introduced after CoW Hooks