This repository was archived by the owner on Feb 2, 2024. It is now read-only.
fix(percentage-display): improve huge surplus display #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks better, but still does not fixes this (#462): |
anxolin
approved these changes
Jul 13, 2023
Yes, exactly the same use case. Hoping @fairlighteth can do something about it 🤞 |
shoom3301
approved these changes
Jul 14, 2023
elena-zh
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Hey @alfetopito , great!
Small question: is this OK to show an absolute value in green?
I chose to do that to be a stand in replaced for the % in the table. |
|
nice! thanks |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
On top of that (see below), when surplus percentage > 1000, show the surplus amount instead of percentage
Summary
Make huuuge surplus percentages a bit better
From
To
To Test
https://explorer.cow.fi/gc/orders/0x46ef40527001b290757c1e55260f806476ed8561852cdcb93122020901d4018cb93bdd291874d637abed0d7b86e31719031b553364adcd5c?tab=overviewand the orders for this address