Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

feat(batch-graph): special addresses #508

Merged
merged 7 commits into from
Jun 12, 2023
Merged

feat(batch-graph): special addresses #508

merged 7 commits into from
Jun 12, 2023

Conversation

alfetopito
Copy link
Collaborator

Summary

Closes #505

Tagging special addresses

image

For now there are only 2, based on this thread:

  • 0xca771eda0c70aa7d053ab1b25004559b918fe662 -> CoW DAO
  • 0xA03be496e67Ec29bC62F01a428683D7F9c204930 -> Solver Rewards Safe

Using a different icon for special nodes

To Test

  1. Load a regular batch
  • The should be no changes
  1. Load a "special" batch like 0x54450bc55a83276344a4e27b951a82d0d5e1927af0126aaac64b1417eb369868
  • The special icon and label should be used

@vercel
Copy link

vercel bot commented Jun 2, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback

📖 Storybook ↗︎

@alfetopito alfetopito self-assigned this Jun 2, 2023
@alfetopito alfetopito requested review from a team June 2, 2023 14:43
@alfetopito alfetopito force-pushed the 505/special-addresses branch from e62d8b7 to 5382786 Compare June 2, 2023 15:58
Base automatically changed from 505/link-node-to-etherscan to develop June 5, 2023 15:51
@alfetopito alfetopito force-pushed the 505/special-addresses branch from 5382786 to 511a665 Compare June 5, 2023 15:52
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5179219543

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.585%
Totals Coverage Status
Change from base Build 5179206459: 0.0%
Covered Lines: 872
Relevant Lines: 1231
💛 - Coveralls

@elena-zh
Copy link

Hey @alfetopito , great job!
One question: CoW Protocol Buffer icon is not clickable. Is this OK?

image

compare with the Solver Rewards Safe:
image

@alfetopito
Copy link
Collaborator Author

Hey @alfetopito , great job! One question: CoW Protocol Buffer icon is not clickable. Is this OK?

image

compare with the Solver Rewards Safe: image

Hmm yeah, as it's the exact same address as the protocol itself.
Still, will see if I can quickly add it

anxolin
anxolin approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft approve

@anxolin anxolin changed the base branch from develop to release/2.23 June 12, 2023 12:07
@anxolin anxolin mentioned this pull request Jun 12, 2023
Merged
@alfetopito alfetopito merged commit e5c3a86 into release/2.23 Jun 12, 2023
@alfetopito alfetopito deleted the 505/special-addresses branch June 12, 2023 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

@shoom3301 shoom3301 shoom3301 approved these changes

Assignees

@alfetopito alfetopito

Labels
RELEASE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve graph view
5 participants
@alfetopito @coveralls @elena-zh @anxolin @shoom3301