Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

feat(batch-graph): add link to etherscan to nodes #507

Merged
merged 12 commits into from
Jun 5, 2023

Conversation

alfetopito
Copy link
Collaborator

Summary

Part of #505

Add on click handler to graph nodes

Screen.Recording.2023-06-01.at.16.55.45.mov

To Test

  1. Load a batch view
  2. Hover over a node
  • Text color should change to orange
  1. Click on node
  • A new tab to etherscan (or equivalent) should be opened to the respective address

@alfetopito alfetopito self-assigned this Jun 1, 2023
@alfetopito alfetopito requested review from a team June 1, 2023 16:13
@coveralls
Copy link

coveralls commented Jun 1, 2023

Pull Request Test Coverage Report for Build 5179181203

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.585%

Totals Coverage Status
Change from base Build 5145240938: 0.0%
Covered Lines: 872
Relevant Lines: 1231

💛 - Coveralls

@vercel
Copy link

vercel bot commented Jun 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback

📖 Storybook ↗︎

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

{
selector: 'node[label].hover',
style: {
color: theme.orange,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing the cursor here you said doesn't work, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it only accepts here their subset of CSS rules https://js.cytoscape.org/#style

@tukantje tukantje changed the title feat(batch-graph): add link to etherscan to nodes Draft: feat(batch-graph): add link to etherscan to nodes Jun 2, 2023
@tukantje tukantje changed the title Draft: feat(batch-graph): add link to etherscan to nodes feat(batch-graph): add link to etherscan to nodes Jun 2, 2023
* fix: 🐛 add cursor pointer to graph

* fix: 🐛 rerender issue

* fix: 🐛 missing hover states
@alfetopito alfetopito merged commit 9b2b2b8 into develop Jun 5, 2023
@alfetopito alfetopito deleted the 505/link-node-to-etherscan branch June 5, 2023 15:51
@anxolin anxolin mentioned this pull request Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants