fix: fix graph for settlement contract trades #492
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 5111096953
💛 - Coveralls |
There was a problem hiding this comment.
Hey @alfetopito , great!
The app is not crashed. The graph sometimes can be hard to read, but a user can zoom in and out it, and change a view.
Also, was not able to test a 'failed to lead' scenario. I tried blocking requests URLs and switched the internet off, it did not help me to reproduce the case.
Thanks
There was a problem hiding this comment.
As we discussed earlier, i think this graph will be way more visible if we create another node for the settlement.
This way, we can see a difference between the "CoW Protocol: Settlement" (or "CoW Protocol: Batch" --> we could brainstorm on names) and just "CoW Protocol" for this contract acting as a trader.
This way, we can see how it sends shitcoins to the "CoW Protocol: Settlement" and receive WETH
If we use the same node, its hard to visualise.
SOFT APPROVING, just because I think this PR fixes the issues, and this can be re-iterated
|
I will merge as this fix the app crashing and continue working on improving the display in another PR |
Summary
Closes #491
Fixing graph visualization for settlements where the settlement contract is also a trader
Also adding error handling so if the graph ever fails, we'll not crash the app and show an error msg instead:
To Test
0xd78b614d0d5c39d55c516653e8674b73133d2c9bbdf302e5be036de7c6b304e6