Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Ipfs gateway #475

Merged
merged 4 commits into from
May 5, 2023
Merged

Ipfs gateway #475

merged 4 commits into from
May 5, 2023

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented May 3, 2023

Summary

Modifies the gateway so we don't depend on Gnosis one any more.

We default to cloudflare, however, this will be modified by ENV so we use https://ipfs.cow.fi/ipfs

This PR adds the required ENV variable

Related PR

Related to this PR, i had to do this PR to allow me to modify the IPFS gateway

cowprotocol/app-data#24

Technical note

Fixed Elena's reported problem, apparently, it was a non-configurable property, and we were trying to delete it.

If you are curious, I'm using this to check if it can be deleted before doing so
#475

To Test

  1. Make sure the app-data in the orders is loaded using https://ipfs.cow.fi/ipfs using Cloudflare (since our gateway has some permission issues

https://explorer-dev-git-ipfs-gateway-cowswap.vercel.app/orders/0x31dda03282cbf2010826c0bd95bc6fcb050969142b6fb8d4f870b6c32a0bf211fbe87d602f7d7dd511349be4acf58842392124a06452a858?tab=overview

image

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback

📖 Storybook ↗︎

@socket-security
Copy link

socket-security bot commented May 3, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@cowprotocol/[email protected] 0.1.0-alpha.0...0.1.0 None +0/-0 cowprotocol_dev

@anxolin anxolin marked this pull request as draft May 3, 2023 19:03
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make a regular release instead?
There are minimal changes of low impact pending to be released

@anxolin
Copy link
Contributor Author

anxolin commented May 4, 2023

Ok! no problem from my side.

@anxolin anxolin marked this pull request as ready for review May 4, 2023 11:00
@anxolin anxolin requested review from alfetopito and a team May 4, 2023 13:17
@nenadV91 nenadV91 changed the base branch from hotfix/2.20.1 to release/2.21.0 May 4, 2023 13:44
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anxolin
Copy link
Contributor Author

anxolin commented May 5, 2023

Thanks @elena-zh ! this error was un-expected, since I'm only changing the URL. I did a small change to make it more resilient.

I tested to update a document to IPFS, and it worked for me https://cloudflare-ipfs.com/ipfs/QmNpXBgqMCKiKcbSFGSuYLyUmkGd9LXaZA3HMP3hXtMJXX

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@nenadV91 nenadV91 merged commit 1f67473 into release/2.21.0 May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants