-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make a regular release instead?
There are minimal changes of low impact pending to be released
Ok! no problem from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appdata page is not working in the PR https://explorer-dev-git-ipfs-gateway-cowswap.vercel.app/appdata?tab=encode
Thanks @elena-zh ! this error was un-expected, since I'm only changing the URL. I did a small change to make it more resilient. I tested to update a document to IPFS, and it worked for me https://cloudflare-ipfs.com/ipfs/QmNpXBgqMCKiKcbSFGSuYLyUmkGd9LXaZA3HMP3hXtMJXX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
Summary
Modifies the gateway so we don't depend on Gnosis one any more.
We default to cloudflare, however, this will be modified by ENV so we use https://ipfs.cow.fi/ipfs
This PR adds the required ENV variable
Related PR
Related to this PR, i had to do this PR to allow me to modify the IPFS gateway
cowprotocol/app-data#24
Technical note
Fixed Elena's reported problem, apparently, it was a non-configurable property, and we were trying to delete it.
If you are curious, I'm using this to check if it can be deleted before doing so
#475
To Test
using https://ipfs.cow.fi/ipfsusing Cloudflare (since our gateway has some permission issueshttps://explorer-dev-git-ipfs-gateway-cowswap.vercel.app/orders/0x31dda03282cbf2010826c0bd95bc6fcb050969142b6fb8d4f870b6c32a0bf211fbe87d602f7d7dd511349be4acf58842392124a06452a858?tab=overview