Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

435/share invert price fills tab #454

Merged
merged 3 commits into from
Apr 20, 2023
Merged

435/share invert price fills tab #454

merged 3 commits into from
Apr 20, 2023

Conversation

alfetopito
Copy link
Collaborator

Summary

Closes #435

Inverting price across all prices at once on details page

Screen.Recording.2023-04-19.at.18.23.56.mov

To Test

  1. Load an order which has >1 fill, such as 0xb039557adb276e7b46ebfa7c8f4fc092938c8341355d36b45f71409a1595e9f7a3a15567ee4e8a483fabfda28ff309045537dd8464472fb2
  2. Click on invert price in the Overview tab
  • It should invert both prices
  1. Go to fills tab
  • Price should already be inverted in the header and the table
  1. Invert the price in the header
  • All prices should be inverted
  1. Invert the price in a table row
  • All prices should be inverted

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
explorer-dev ✅ Ready (Inspect) Visit Preview Apr 19, 2023 5:28pm

@alfetopito alfetopito self-assigned this Apr 19, 2023
@alfetopito alfetopito requested review from a team April 19, 2023 17:28
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4746193171

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.543%
Totals Coverage Status
Change from base Build 4720183737: 0.0%
Covered Lines: 872
Relevant Lines: 1231
💛 - Coveralls

shoom3301
shoom3301 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@shoom3301 shoom3301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

elena-zh
elena-zh approved these changes Apr 20, 2023
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@alfetopito alfetopito merged commit e7b3b00 into develop Apr 20, 2023
@alfetopito alfetopito deleted the 435/share-invert-price-fills-tab branch April 20, 2023 12:43
@nenadV91 nenadV91 mentioned this pull request May 4, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoom3301 shoom3301 shoom3301 approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.20]Orders fills: share invertPrice state between the header and body
4 participants
@alfetopito @coveralls @shoom3301 @elena-zh